feat(cdk): dev-mode command #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wanna develop a new CDK component? Run the command: ``` lacework component dev <component_name> ``` Signed-off-by: Salim Afiune Maya <[email protected]>
hazedav
approved these changes
Oct 18, 2022
| } | ||
|
|
||
| if component.UnderDevelopment() { | ||
| return errors.New("component already under development.") |
There was a problem hiding this comment.
nit: do you want to return an error here or just nil and output info?
Comment on lines
+83
to
+88
| componentsDevModeCmd = &cobra.Command{ | ||
| Use: "dev <component>", | ||
| Hidden: true, | ||
| Short: "Enter development mode of a new or existing component", | ||
| Args: cobra.ExactArgs(1), | ||
| RunE: runComponentsDevMode, |
There was a problem hiding this comment.
nit: I know this is hidden, but a 'long' description with more details on cmd usage would be nice.
| component, found := cli.LwComponents.GetComponent(args[0]) | ||
| if !found { | ||
| component = &lwcomponent.Component{ | ||
| Name: args[0], |
There was a problem hiding this comment.
Should there be any restrictions on a component name. For example I could pass in "!"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wanna develop a new CDK component? Run the command:
Signed-off-by: Salim Afiune Maya [email protected]
How did you test this change?
ddev-mode.mp4
Issue
https://lacework.atlassian.net/browse/ALLY-1186