fix: moved DEFAULT_BASE_DOMAIN to object instantiation (#101)

lacework · Jan 9, 2023 · 4e3e58d · 4e3e58d
1 parent aa5edbd
commit 4e3e58d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/laceworksdk/api/__init__.py b/laceworksdk/api/__init__.py
@@ -53,6 +53,7 @@
 from .v2.vulnerability_policies import VulnerabilityPoliciesAPI
 
 from laceworksdk.config import (
+    DEFAULT_BASE_DOMAIN,
     LACEWORK_ACCOUNT_ENVIRONMENT_VARIABLE,
     LACEWORK_SUBACCOUNT_ENVIRONMENT_VARIABLE,
     LACEWORK_API_KEY_ENVIRONMENT_VARIABLE,
@@ -99,7 +100,8 @@ def __init__(self,
         self._api_secret = api_secret or os.getenv(
             LACEWORK_API_SECRET_ENVIRONMENT_VARIABLE)
         self._base_domain = base_domain or os.getenv(
-            LACEWORK_API_BASE_DOMAIN_ENVIRONMENT_VARIABLE)
+            LACEWORK_API_BASE_DOMAIN_ENVIRONMENT_VARIABLE
+        ) or DEFAULT_BASE_DOMAIN
 
         config_file_path = os.path.join(
             os.path.expanduser("~"), LACEWORK_CLI_CONFIG_RELATIVE_PATH)

diff --git a/laceworksdk/http_session.py b/laceworksdk/http_session.py
@@ -13,7 +13,6 @@
 
 from laceworksdk import version
 from laceworksdk.config import (
-    DEFAULT_BASE_DOMAIN,
     DEFAULT_ACCESS_TOKEN_EXPIRATION,
     DEFAULT_SUCCESS_RESPONSE_CODES,
     RATE_LIMIT_RESPONSE_CODE
@@ -52,7 +51,7 @@ def __init__(self, account, subaccount, api_key, api_secret, base_domain):
         # Set the base parameters
         self._api_key = api_key
         self._api_secret = api_secret
-        self._base_domain = base_domain or DEFAULT_BASE_DOMAIN
+        self._base_domain = base_domain
 
         self._base_url = f"https://{account}.{self._base_domain}"
         self._account = account