Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Composite auth adapter #17

Open
3 tasks
weierophinney opened this issue Dec 31, 2019 · 3 comments
Open
3 tasks

[WIP] Composite auth adapter #17

weierophinney opened this issue Dec 31, 2019 · 3 comments

Comments

@weierophinney
Copy link
Contributor

As originally proposed in #65

This PR adds the possibility to use multiple authentication adapters under the same type.

It also introduces an AdapterAbstractFactory that allows to retrieve each adapter from the ServiceManager under the naming convention zf-mvc-auth-authentication-adapters-{type}.
This enables a new method to register custom adapters: using a service name the adapter key of a named adapter configuration.

TO-DO:

  • Provide a way to use the composite adapter as a default one for all APIs
  • Integration Tests
  • Update the README

Originally posted by @stefanotorresi at zfcampus/zf-mvc-auth#76

@weierophinney weierophinney added Enhancement New feature or request 2 - Working labels Dec 31, 2019
@weierophinney
Copy link
Contributor Author

@stefanotorresi This looks fantastic! Any chance you can wrap up the lingering todo items soonish?


Originally posted by @weierophinney at zfcampus/zf-mvc-auth#76 (comment)

@weierophinney
Copy link
Contributor Author

@weierophinney been a bit busy lately, but I'll try to attend to this before the end of this week!


Originally posted by @stefanotorresi at zfcampus/zf-mvc-auth#76 (comment)

@weierophinney
Copy link
Contributor Author

@stefanotorresi I pulled this locally, rebased it off of current develop, and tried to push to your branch... but could not. So I did a PR for you: stefanotorresi/zf-mvc-auth#1

The tasks you have listed above are still incomplete, and, honestly, I'm unsure how to complete the first 2. If you would like to continue with this patch, please merge the PR I sent you, and push changes back to your branch when complete.

Thanks!


Originally posted by @weierophinney at zfcampus/zf-mvc-auth#76 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants