Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZF3][RFC] View refactoring #24

Open
weierophinney opened this issue Dec 31, 2019 · 0 comments
Open

[ZF3][RFC] View refactoring #24

weierophinney opened this issue Dec 31, 2019 · 0 comments

Comments

@weierophinney
Copy link
Member

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/3935
User: @MatyCZ
Created On: 2013-03-02T15:28:49Z
Updated At: 2014-06-12T10:51:43Z
Body

  • Model options is now situated in separated classes
  • Renderer options is now situated in separated classes too
  • Model options passed to constructor now change model behaviour (options don't have any effect before update)
  • CS fixes
  • Code cleanup
  • Some helpers was modified
  • Create a lot of unexsist property in test classes
  • Create a lot of new tests

Comment

User: @prolic
Created On: 2013-03-02T19:33:37Z
Updated At: 2013-03-02T19:33:37Z
Body
looks good on first sight


Comment

User: @weierophinney
Created On: 2013-03-11T21:39:20Z
Updated At: 2013-03-11T21:39:20Z
Body
I think there are some great ideas here. However, you've removed methods that existed on the view models, and also removed methods from interfaces -- which means that functionality that was consumed before no longer will work. In other words, it's not backwards compatible.

That said, I still think they're good ideas; I've simply changed the milestone to 3.0.0, as that will be the earliest we can make these changes.


Comment

User: @MatyCZ
Created On: 2013-06-12T10:09:52Z
Updated At: 2013-06-12T10:09:52Z
Body
There is one Test which fails but I don't understand why:

Zend\View\ViewTest::testModelFromEventIsUsedByRenderer



Originally posted by @GeeH at zendframework/zend-view#72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant