Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when calling synchronized on AnyVal #18021

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Warn when calling synchronized on AnyVal #18021

merged 1 commit into from
Jul 12, 2023

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Jun 20, 2023

Fixes #17284. Done during the Dotty Issue Spree of June 20, 2023.

tests/neg/17284.scala Outdated Show resolved Hide resolved
tests/neg/17284.scala Outdated Show resolved Hide resolved
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Should squash commits and maybe rebase.

compiler/src/dotty/tools/dotc/reporting/messages.scala Outdated Show resolved Hide resolved
Co-Authored-By: James You <[email protected]>
Co-Authored-By: diogocanut <[email protected]>
Co-Authored-By: Nicolas Stucki <[email protected]>
@mbovel
Copy link
Member Author

mbovel commented Jul 12, 2023

Rebased ✅

@mbovel mbovel merged commit 5982592 into scala:main Jul 12, 2023
17 checks passed
@mbovel mbovel deleted the 17266 branch July 12, 2023 11:31
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
Kordyjan added a commit that referenced this pull request Dec 8, 2023
Backports #18021 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan modified the milestones: 3.4.0, 3.3.2 Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Generate warnings when synchronized on AnyVal
3 participants