Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for primary constructor in namePresentInSource #18325

Merged
merged 1 commit into from
Aug 3, 2023
Merged

check for primary constructor in namePresentInSource #18325

merged 1 commit into from
Aug 3, 2023

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented Aug 2, 2023 •
edited
Loading

fixes #18319

note that we still do not produce occurrences for the primary constructor's own parameters, it seems in scala 2 implementation only the local backing field has occurrences.

@bishabosha bishabosha requested review from Kordyjan and tgodzik and removed request for Kordyjan August 2, 2023 09:39
tgodzik
tgodzik approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should we create a new issue for the parameters?

@bishabosha
Copy link
Member Author

Looks good! Should we create a new issue for the parameters?

only if there is a need, it seems the scala 2 implementation doesn't record them either

@bishabosha bishabosha added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Aug 3, 2023
@bishabosha bishabosha merged commit ee9d929 into scala:main Aug 3, 2023
17 checks passed
@bishabosha bishabosha deleted the semanticdb/fix-ctor-occurrences branch August 3, 2023 12:55
@tgodzik
Copy link
Contributor

tgodzik commented Aug 3, 2023

Looks good! Should we create a new issue for the parameters?

only if there is a need, it seems the scala 2 implementation doesn't record them either

I think they are not needed, but I found an issue to be fixed in MEtals. Anyway, thanks for dealing with this!

@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 10, 2023
@Kordyjan Kordyjan mentioned this pull request Dec 1, 2023
Merged
Kordyjan added a commit that referenced this pull request Dec 8, 2023
@Kordyjan
Backport "check for primary constructor in namePresentInSource" to LTS (
0794f6d 
#19146)

Backports #18325 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees

@tgodzik tgodzik

Labels
None yet
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.

SemanticDB does not include symbol occurrence of constructor
3 participants
@bishabosha @tgodzik @Kordyjan