Fix expandParam's use of argForParam/isArgPrefixOf. #19412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Jan 10, 2024
| @@ -6276,7 +6276,7 @@ object Types extends TypeUtils { | |||
| */ | |||
| def expandParam(tp: NamedType, pre: Type): Type = | |||
| tp.argForParam(pre) match { | |||
| case arg @ TypeRef(pre, _) if pre.isArgPrefixOf(arg.symbol) => | |||
| case arg @ TypeRef(`pre`, _) if pre.isArgPrefixOf(arg.symbol) => | |||
There was a problem hiding this comment.
Hah, we really need a shadowing warning for this.
There was a problem hiding this comment.
Yeah, probably. Obviously it's worst when the types match up exactly, but I've definitely shadowed things intentionally, ala port.parse.match { case Some(port) => ... }, so hard to find the right ergonomics...
Kordyjan
added
the
backport:nominated
Kordyjan
added
backport:accepted
Kordyjan
added
backport:done
Kordyjan
added a commit
that referenced
this pull request
Jan 31, 2024
Backports #19412 to 3.3.2 LTS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19354