Add patch for undefined behavior with object $
#19705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an ad-hoc patch to make it possible to use the broken `object $` definitions in https://github.com/com-lihaoyi/Ammonite/blob/main/amm/interp/api/src/main/scala/ammonite/Stubs.scala. This is a temporary patch while these definitions get deprecated. There is not guarantee that the semantics of these objects are correct. There is also no way to adapt the spec to allow there definition without breaking the language. For example consider `object $` and `object $$`, how would we know if the `$$.class` is the class of `$$` or the module class of `$`. We need to know this before we read the file.
bishabosha
reviewed
Feb 19, 2024
| // Special case for `object $` in Amonite. | ||
| // This is an ad-hoc workaround for Amonite `object $`. See issue #19702 | ||
| // This definition is not valid Scala. | ||
| && classOrModuleName != "$" |
There was a problem hiding this comment.
so for clarity object $ makes $$.class, $.class, and $.tasty.
$$.class => $.tasty via standard code path
$.class => $.tasty via this escape hatch
bishabosha
approved these changes
Feb 19, 2024
This was referenced Jun 4, 2024
lihaoyi
pushed a commit
to com-lihaoyi/Ammonite
that referenced
this pull request
Jun 10, 2024
Added 3.4.2 to targets in a fairly straightforward, formulaic fashion. 3.4.0 and 3.4.1, for good reason, fail to parse `$` as a class file, but a [temporary ad-hoc workaround was added in 3.4.2](scala/scala3#19705), so this needn't block 3.4 support for now. Reliance on `object $` still needs to be [fixed in Ammonite](#1395). Several internals changes required fixes also; I used the most obvious solution (e.g. if Y extends X and Y is now private, use X instead), but someone who knows more might want to read it over. Tests pass on my machine for 3.3 and 3.4.2 (under Java 21). If accepted, this patch would supersede #1394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an ad-hoc patch to make it possible to use the broken
object $definitions in https://github.com/com-lihaoyi/Ammonite/blob/main/amm/interp/api/src/main/scala/ammonite/Stubs.scala.This is a temporary patch while these definitions get deprecated. There is not guarantee that the semantics of these objects are correct. There is also no way to adapt the spec to allow there definition without breaking the language. For example consider
object $andobject $$, how would we know if the$$.classis the class of$$or the module class of$. We need to know this before we read the file.Closes #19702