Preventing compilation of a @tailrec method when it does not rewrite, but an inner method does #20143
Conversation
|
Sorry, I complained about having to rewrite error IDs repeatedly. Probably there is a way to make that part of the build. Or maybe they use it as a rite of passage of sorts. |
No worries. I've had much much worse hand numbered files to merge in my time. |
LucySMartin
force-pushed
the
nested-tailrec-defs
branch
from
f510492
to
73aae73
Compare
LucySMartin
force-pushed
the
nested-tailrec-defs
branch
from
dea5b00
to
a841499
Compare
|
@LucySMartin What's the status of this PR? Do you need help getting the CI to pass? |
|
Sorry for leaving this abruptly - ill be back in the sane world on Monday
and can pick this up then.
…On Mon, 10 Jun 2024, 13:35 Sébastien Doeraene, ***@***.***> wrote:
@LucySMartin <https://github.com/LucySMartin> What's the status of this
PR? Do you need help getting the CI to pass?
—
Reply to this email directly, view it on GitHub
<#20143 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHKD6J62N2FDN5KDLGSU5TLZGWMQFAVCNFSM6AAAAABF7AP352VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJYGIZDQMJZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Please ignore the excess off way too many commits. Was fighting either git or the build as it kept putting /weird/ CR and LF tokens into things. |
|
@sjrd - I'm really sorry but I've given this a few attempts to get line endings correct, but its just not working on the remote. Are there some standard git settings or arcane windows magic I would need to do to get these things to generate with the correct line endings? |
|
On Windows I strongly suggest disabling the "autocrlf" config. I even recommend to that globally. git pretends to be "helpful" with that setting but I have never seen it useful and always harmful. To disable it: $ git config --global core.autocrlf falsetaken from the git book |
|
Offering sympathies. I never develop on Windows, but a fellow at the office did and we went through this rigmarole. I just read that the U.S. Surgeon General will require a warning on the package for |
|
Yeah - I turned autocrlf off for the reattempt today (and have nuked it on other projects too - I agree from the docs its just bad). I saw that comparable check files were just LF (please correct me if that's not right!) so stripped the files down to just LF by hand, and copied them across. I'm honestly not sure what is wrong with them, and (sorry if this is a problem with my limited use of github) I cant see any way to view what files were actually generated via the CI tests, to validate what line endings its generated in the server side .out files. |
|
Im an idiot - I see the issue. |
There was a problem hiding this comment.
Note to self: drop this when sqashing commits.
…ons contain non-tail recursive calls. Code will now compile where a child def calls the parent def in a non-tail position (with the warning). Code will no longer compile if all calls to a @tailrec method are in named child methods (as these do not tail recurse).
LucySMartin
force-pushed
the
nested-tailrec-defs
branch
from
04abdf0
to
01ada74
Compare
|
Thanks. Is it intended that the commit is not linked to your GitHub account? That's not a problem for us, but it means you won't get the statistics in your favor. :p |
|
Note in addition to the squash I removed the hex-logging of the comparison. |
|
Anything I need to do to merge this at this point? |
|
In case sjrd's comment was overlooked, the commit author is I had that issue once, but I don't remember how I managed my .gitconfig, maybe with a project-specific one? (I was visiting this PR in order to align Scala 2.) |
|
Oh oops. |
Adding warnings if there is an annotated def at the top level that is referenced from an inner def
Fixes #20105