Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #20267 with regression test #20506

Merged
merged 1 commit into from
Jun 2, 2024
Merged

fix issue #20267 with regression test #20506

merged 1 commit into from
Jun 2, 2024

Conversation

bishabosha
Copy link
Member

As mentioned in #20267, the new desugaring from #20497 seems to fix the issue

fixes #20267

EugeneFlesselle
EugeneFlesselle approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@EugeneFlesselle EugeneFlesselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the original issue, it's unfortunate the type level ops don't work well with precise types

But avoiding those problems for named tuples is definitely an improvement 👍

@bishabosha bishabosha merged commit cfc51b0 into scala:main Jun 2, 2024
19 checks passed
@bishabosha bishabosha deleted the named-tuples-i20267 branch June 2, 2024 18:23
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneFlesselle EugeneFlesselle EugeneFlesselle approved these changes

Assignees

@EugeneFlesselle EugeneFlesselle

Labels
None yet
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.

Named Tuples don't propagate singleton types as widely as tuples
3 participants
@bishabosha @EugeneFlesselle @Kordyjan