Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lagoon init/pull/push improvements #11

Open
pirog opened this issue Nov 12, 2020 · 1 comment
Open

Lagoon init/pull/push improvements #11

pirog opened this issue Nov 12, 2020 · 1 comment
Assignees

Comments

@pirog
Copy link
Member

pirog commented Nov 12, 2020

We're feature complete on Lagoon init/pull/push but there are a few areas we could and should improve:

  1. On init/pull/push when you see a list of "authorizations" to use this is expressed as emails but it should also probably include the lagoon instance url. We also should probably remove "duplicates" eg only show the latest authorization for a given email/lagoon combination.
  2. We do a lot of unneeded calls to the Lagoon API because we are creating multiple instances of the Lagoon API client. We should share a single client instance so that we do not need to make unneeded calls. Eg calling api.auth should just return this.token if its set instead of authing again. Ditto for api.getProjects. NOTE: @mikemilano had it this way originally but @pirog removed it for expediency and because his brain was hurting.
@stale
Copy link

stale bot commented Jun 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

@rtfm-47 rtfm-47 transferred this issue from lando/lando Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants