Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the MMR computations to the actual metric being used in the vstore #74

Open
hemidactylus opened this issue Sep 18, 2024 · 0 comments

Comments

@hemidactylus
Copy link
Collaborator

Ah, ... there's a more conceptual thing that's bugging me (and to be clear it also affects the VectorStore I myself wrote, lol).
We offer all 3 similarities Astra has (ok, dot == cosine where it makes sense to use it. But still there's Euclidean).
Yet the MMR always assumes a cosine metric to do its MMR thing. I think in some cases it could lead to very suboptimal/surprising reranking results.
I would consider filing an issue (for the future) whereby the measure used within the MMR step matches the one of the vector store (which is probably what the user intuitively expects).
(granted, lambda_mult values would not have the same meaning across metrics, ... so what? Folks would tune to their metric of choice)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant