PR Review Process

[efriis]

In order to enhance the LangChain contributor experience and clarify some of the processes around PR review, we have added this Review Process page to the documentation.

https://python.langchain.com/docs/contributing/review_process/

We're catching up on "triaging" the backlog of pull requests this week.

Let us know if you have feedback on or questions about the process below!

[MacanPN]

Could you please clarify how does the needs support status work? You mention that PRs with this status are "Automatically promoted to the backlog if it receives 5 upvotes." I'm not aware that PRs themselves have "upvote" functionality? Do thumbs up on PR description count? Further down it is mentioned that "... if they do not get enough support (measured by upvotes or comments)". How do comments enter the equation? Are upvotes on these comments also counted as a support? Or is it mostly eyeballed? Thanks!

[eyurtsev]

You can add an emoji 👍 to a PR

e.g., https://github.com/langchain-ai/langchain/pulls?q=is%3Apr+is%3Aopen+sort%3Areactions-%2B1-desc

[Davi-Schumacher]

I had this question too. Can we get this into the review_process doc?

[michaelfeil]

I am unhappy about this extreme measure taken by langchain. I have written the early integrations with https://github.com/michaelfeil/infinity and reviewed the integrations of others. #27043

I am used to that a ISSUE might be de-prioritized. I have not heard of a software project that forbids PR's that need to have a certain amount of likes.

[efriis]

Hey there! We're adding some docs in the coming weeks for how you can self-maintain an external package that may be relevant to your project. Will add a link here when they're in!

This process isn't meant to forbid PRs but instead surface which new integrations that were contributed without an associated issue are worth prioritizing among the maintainers, and make explicit which ones are unlikely to get eyes in a reasonable amount of time. We recognize it's not perfect, and hopefully it's better than previous lack of clarity.

[michaelfeil]

Thank you! Yes it could be helpful. I am pushing the integration into langchain, as users demand "how can I use your repo with langchain".

It would be great to host extensive doc material so that users can be redirected to use the external package.