From 993f49ef1db2ace223b4f1fbc716c2e1e3262212 Mon Sep 17 00:00:00 2001 From: Jonas Staudenmeir Date: Mon, 16 Sep 2019 17:44:46 +0200 Subject: [PATCH] Improve detection of latest stable ChromeDriver release --- src/Console/ChromeDriverCommand.php | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/Console/ChromeDriverCommand.php b/src/Console/ChromeDriverCommand.php index 81c17c88b..b825e2945 100644 --- a/src/Console/ChromeDriverCommand.php +++ b/src/Console/ChromeDriverCommand.php @@ -29,14 +29,14 @@ class ChromeDriverCommand extends Command protected $description = 'Install the ChromeDriver binary'; /** - * URL to the home page. + * URL to the latest stable release version. * * @var string */ - protected $homeUrl = 'http://chromedriver.chromium.org/home'; + protected $latestVersionUrl = 'https://chromedriver.storage.googleapis.com/LATEST_RELEASE'; /** - * URL to the latest release version. + * URL to the latest release version for a major Chrome version. * * @var string */ @@ -165,11 +165,7 @@ protected function version() */ protected function latestVersion() { - $home = $this->getUrl($this->homeUrl); - - preg_match('/release:.*?\?path=([\d.]+)/', $home, $matches); - - return $matches[1]; + return trim(file_get_contents($this->latestVersionUrl)); } /**