Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel/Framework Updated to 5.1.24 but Some Files didn't changed. #10968

Closed
justmyfreak opened this issue Nov 16, 2015 · 12 comments
Closed

Laravel/Framework Updated to 5.1.24 but Some Files didn't changed. #10968

justmyfreak opened this issue Nov 16, 2015 · 12 comments

Comments

@justmyfreak
Copy link

Currently I have issue running IronMQ on Laravel 5.1 and opened issue #10828. The issue has been fixed trough pull request #10848. So I updated my laravel/framework to v5.1.24. But files merged with pull request #10848 didn't changed on my vendor.

I've removed all vendor, then clear composer cache before running composer install again.

I also got Class 'IronMQ\IronMQ' not found error. I'm using "iron-io/iron_mq": "4.*" on my composer.json.

@GrahamCampbell
Copy link
Member

In the meanwhile v2 will still work. Seems v4 isn't even namespaced anymore. I've got no idea what the ironmq devs are doing...

@justmyfreak
Copy link
Author

Too bad.
I got endpoint error when using v2 of IronMQ.

@GrahamCampbell
Copy link
Member

You need to switch to the old API. There must be something in the settings to do that.

@justmyfreak
Copy link
Author

Thanks, I'll look into it

@carvefx
Copy link

carvefx commented Nov 26, 2015

Hi, I also ran into the same issue as @justmyfreak
After doing some digging it seems like the changes from this commit: ad8ce4c

do not exist on the tagged v5.1.24 release
https://github.com/laravel/framework/blob/v5.1.24/src/Illuminate/Queue/Jobs/IronJob.php#L86
for some reason, which leads to the vendor/* files not being updated on composer update

Bad merge? Am I missing something?

@GrahamCampbell
Copy link
Member

It's in the process of getting reverted.

@carvefx
Copy link

carvefx commented Nov 26, 2015

so is v5.1.25 going to include the fix?

@GrahamCampbell
Copy link
Member

No.

@GrahamCampbell
Copy link
Member

Taylor will explain in more detail soon. :)

@carvefx
Copy link

carvefx commented Dec 3, 2015

any updates on this @GrahamCampbell ?

@oscarbatlle
Copy link

Any updates on this @GrahamCampbell ?

@GrahamCampbell
Copy link
Member

Yes. We reverted the changes. Only v2 is supported. Also note that all ironmq support was removed from L5.2. It's been moved to the community to maintain. Feel free to go to that laravel collective repo and ask them to support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants