Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db:seed --class=blahblah has no response #11375

Closed
z1haze opened this issue Dec 17, 2015 · 9 comments
Closed

db:seed --class=blahblah has no response #11375

z1haze opened this issue Dec 17, 2015 · 9 comments

Comments

@z1haze
Copy link

z1haze commented Dec 17, 2015

Hey, Just wanted to point out a tiny bug. When you run the database seeder and specify the seeder file with class=ClassNameHere you dont get any response back in the console such as Seeded: ClassNameHere

Nothing important, but I just wanted to share this with you in case you didnt know.

@GrahamCampbell
Copy link
Member

I can't replicate. You should get an exception thrown.

@GrahamCampbell
Copy link
Member

The code looks like this:

    /**
     * Get a seeder instance from the container.
     *
     * @return \Illuminate\Database\Seeder
     */
    protected function getSeeder()
    {
        $class = $this->laravel->make($this->input->getOption('class'));

        return $class->setContainer($this->laravel)->setCommand($this);
    }

@alexhouse
Copy link

I think the issue is if you specify a class to seed (that exists), artisan doesn't provide any confirmation output (unlike just calling db:seed with no arguments where you get information on the classes that get seeded)

@GrahamCampbell
Copy link
Member

I think that's right?

@alexhouse
Copy link

Technically, yes. Perhaps there's risk of confusion, though, as calling db:seed confirms every seeder that runs, but calling an individual one doesn't necessarily output that execution is successful, it just errors if something goes wrong.

@z1haze
Copy link
Author

z1haze commented Dec 17, 2015

Ok well whether it's a bug or not I just think it should provide output of success. Every other artisan function I've used seems to provide some sort of feedback

Sent from my iPhone, sorry about the typos.

On Dec 17, 2015, at 9:05 AM, Alex [email protected] wrote:

I think the issue is if you specify a class to seed (that exists), artisan doesn't provide any confirmation output (unlike just calling db:seed with no arguments where you get information on the classes that get seeded


Reply to this email directly or view it on GitHub.

@mbrioski
Copy link

mbrioski commented Jun 29, 2018

Just FYI, this is not solved also in the Version (5.3).
The bug is a little bit different: you get an output if the class doesn't exist.
If the feed is executed then you have not output.

@z1haze
Copy link
Author

z1haze commented Jul 5, 2018

Yes, all I ever had mentioned was there was no success feedback after running db:seed and specifying a seeder, but you get success feedback when you call db:seed without any arguments. I believe it should be consistent.

@z1haze
Copy link
Author

z1haze commented Oct 2, 2018

Great, only took 3 years!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants