Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to set maxAttempts for queued Notifications #26175

Closed
tiawleong opened this issue Oct 18, 2018 · 2 comments
Closed

No way to set maxAttempts for queued Notifications #26175

tiawleong opened this issue Oct 18, 2018 · 2 comments

Comments

@tiawleong
Copy link

tiawleong commented Oct 18, 2018 •
edited by driesvints
Loading

  • Laravel Version: 5.6
  • PHP Version: 7.2.2

Description:

Illuminate/Notifications/SendQueuedNotifications does not have the $tries property, so maxAttempts is always null when Notifications are queued. Failed notifications are retried without limit.
Please consider implementing the $tries property for this Class like what done for SendQueuedMail in this old Pull Request : #18103
@driesvints
Copy link
Member

Think this is something we can add yeah. Feel free to send in a PR.

@driesvints
Copy link
Member

To the 5.7 branch I mean.

@therealartz therealartz mentioned this issue Nov 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@driesvints @tiawleong