App::environment() ignores APP_ENV when --env option is used on cli

[redelschaap]

• Laravel Version: 5.8.15
• PHP Version: 7.3.4

Description:

The documentation says that "The current application environment is determined via the APP_ENV variable from your .env file.". It also says that "The current application environment detection can be overridden by a server-level APP_ENV environment variable."

However, when using artisan with the --env option, App::environment() will return the value of the --env option. To me as a developer, I find it logical that the --env option is used to determine the .env file to use, not to overrule the environment. After all, the name of the .env file can differ from the APP_ENV value in that file.

Steps To Reproduce:

1. Copy the .env file to .env.foo;
2. Change the value of APP_ENV within .env.foo to bar;
3. Run php artisan tinker;
4. Execute the command App::environment(), the value of APP_ENV should be returned;
5. Quit Tinker and run php artisan tinker --env=foo;
6. Execute the command App::environment();
7. foo is now returned, instead of bar.

[khflab]

• Laravel Version: 5.8.17
• PHP Version: 7.1.13
• OS: Windows 10

I was able to reproduce it

[driesvints]

I can't test this atm because my tinker environment is still broken after bobthecow/psysh#540 so it would be cool if some more people could verify this.

[rdarcy1]

I can reproduce

• Laravel Version: 5.8.24
• PHP Version: 7.2.17
• OS: MacOS 10.14

It seems like this is expected functionality (see Illuminate\Foundation\EnvironmentDetector) but perhaps there should be different flags for the .env file and the value of APP_ENV?

[redelschaap]

I think that will be a good solution.

[Tarasovych]

#28668 related a bit

[driesvints]

Going to close this as we don't consider this a bug. Please see the remark by Taylor here: #28982 (comment)