-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ngrok integration #1324
Comments
@caseysoftware We currently only have one ngrok binary that seems to somehow work for all Macs. Will I have to differentiate which architecture they're on when I update? I went to download the latest binary and I see I have to pick the architecture (https://ngrok.com/download) Thanks! |
We did some digging on our end. In the current setup, you have the x86_64 version of v2.3.40 and it generally appears to work, likely because of Rosetta 2:
So the immediate solution should be to embed the current version (3.1) of the x86_64 binary and it should continue to work. Alternatively, you could add both arm & x86 of v3.1 and re-use this PR to let the uname make the call: |
OK, fantastic! I'll look into these two options. Thanks @caseysoftware! |
In the end I actually moved ngrok to be installed via Brew. 😆 |
I'm updating the Ngrok binary in Valet v4, and may move it to be managed by Brew; at @caseysoftware's suggestion I'll also just update the binary bundled with v3 in a minor release.
Also, I want to add an easy command to pass in your authentication token. It'll be something like
and it'll pass it through to
... update, our old version seems to instead use
To do:
set-ngrok-token
command (Addset-ngrok-token
command #1325)set-ngrok-token
commandThe text was updated successfully, but these errors were encountered: