Syntactic sugar: Tree.has_data()

[makukha]

Suggestion
Add new method Tree.has_data(data: str) -> bool to determine whether there is a token with given data.

Describe alternatives you've considered
This can be achieved with find_data() method, but is too verbose:

try:
    next(tree.find_data(data))
except StopIteration:
    has_data = False
else:
    has_data = True

compared to

tree.has_data(data)

Additional context
I'm ready to provide PR if you find this API enhancement reasonable.

[erezsh]

I can suggest

has_data = bool(next(tree.find_data(data), False))

[erezsh]

Another option is:

for _ in tree.find_data(data):
   # do if true
   break

I understand having a method would be a bit more ergonomic, but I feel like it's a bit too small to be worth adding.

But I'll leave it open, if more users would like this method, we can add it in.

[makukha]

I can suggest

has_data = bool(next(tree.find_data(data), False))

Thank you, this one is pretty close. I've forgotten about the next()'s default arg.

However, it will not work when next(tree.find_data(data)) == False itself.

[erezsh]

Yeah. Honestly, I don't know why itertools doesn't have this method:

EMPTY = object()
def iter_is_empty(i) -> bool:
    return next(i, EMPTY) is EMPTY

[makukha]

It seems that people will tend to choose readability over performance:

has_data = bool(tuple(tree.find_data(data)))

(at least I will)