Attempt at porting to zio2 #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barambani
previously approved these changes
Nov 25, 2022
barambani
approved these changes
Nov 25, 2022
sirocchj
commented
Nov 25, 2022
| @@ -231,7 +235,7 @@ final class ConsoleLogWriterTest extends AnyWordSpecLike with Matchers with zio. | |||
| "created with level Trace" should { | |||
| "log all the messages" in { | |||
| val out = capturedConsoleOutOf { | |||
| val cl = consoleLogUpToLevel(Trace) | |||
| val cl = consoleLogUpToLevel(log.effect.LogLevels.Trace) | |||
There was a problem hiding this comment.
for the record, no idea why this was needed, but not in all other cases...
There was a problem hiding this comment.
It's ambiguous with zio.Trace I guess.
There was a problem hiding this comment.
Yeah, you're absolutely right.. I'll create a mini-PR to hide it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dunno 🤷♂️