Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for key comparison and getting public key data from EdDSA #272

Closed
Jakuje opened this issue Aug 3, 2023 · 3 comments · Fixed by #292 or #379
Closed

Test coverage for key comparison and getting public key data from EdDSA #272

Jakuje opened this issue Aug 3, 2023 · 3 comments · Fixed by #292 or #379
Assignees
Labels
enhancement New feature or request

Comments

@Jakuje
Copy link
Contributor

Jakuje commented Aug 3, 2023

The PR #267 added key comparison test tcmpkeys which runs for RSA and EC keys, but there is no test coverage for EdDSA keys. The implementation should be complete though.

It also added reading of public attributes from the generated keys in tgenkey, but also without EdDSA coverage, which needs to be added somehow separately (as the EdDSA is available only in SoftHSM for now).

BTW when is the NSS getting EdDSA support? There were some patches, werent they?

@Jakuje Jakuje added the enhancement New feature or request label Aug 3, 2023
@Jakuje Jakuje changed the title Test coverage for key comparison anof EdDSA Test coverage for key comparison and getting public key data from EdDSA Aug 3, 2023
@simo5 simo5 self-assigned this Apr 12, 2024
@simo5
Copy link
Member

simo5 commented Apr 12, 2024

I am trying to extend the simple pub key loading tests, but I get a failure to load the public key from the produce pem file.

A quick gdb of the test shows OSSL_STORE_INFO_get_type() returning an entry of type OSSL_STORE_INFO_PARAMS which confuses me.

@simo5
Copy link
Member

simo5 commented Apr 12, 2024

Apparently have to explicitly tell the store to expect a public key, otherwise it attempts to load a private key and gets only params ... somehow...

@simo5 simo5 mentioned this issue Apr 12, 2024
10 tasks
@Jakuje
Copy link
Contributor Author

Jakuje commented Apr 13, 2024

Apparently have to explicitly tell the store to expect a public key, otherwise it attempts to load a private key and gets only params ... somehow...

This works as a workaround for the key comparison, but usually one wants also the private key.

Anyway most of this (except the proposed workaround) is already described in #292, in openssl/openssl#22246 and likely fixed in ossl 3.2 (openssl/openssl/pull#21219).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants