Side-channel proofing PKCS#1 1.5 paths (CVE-2023-6258) #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
force-pushed
the
pkcs1_marvin
branch
3 times, most recently
from
5a7643e
to
a2c4b09
Compare
tomato42
reviewed
Nov 14, 2023
tomato42
approved these changes
Nov 14, 2023
|
Just to be explicit: the "approved" status is because they look fine, not because I've verified them to be side-channel free. |
That was understood, |
|
this issue was assigned CVE-2023-6258 |
simo5
changed the title
Fixes CVE-2023-6258 (Marvin) Signed-off-by: Simo Sorce <[email protected]>
|
Merging this now that debian fixes are in and all tests pass, macos softoken is still broken because the CI still uses the broken NSS versions and the softhsm for other reasons that seem also macports related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for CVE-2023-6258 (Marvin)