Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect CIN when sending system messages #8

Closed
YuuichiAkagawa opened this issue May 5, 2021 · 2 comments
Closed

Incorrect CIN when sending system messages #8

YuuichiAkagawa opened this issue May 5, 2021 · 2 comments

Comments

@YuuichiAkagawa
Copy link
Contributor

incorrectCIN

Arduino-USBMIDI/src/USB-MIDI.h

Lines 76 to 77 in 3cc162d

cin = system2cin[status & 0x0F][1];
mPacket.header = MAKEHEADER(cableNumber, 0x04);

I think the second argument is cin.

 mPacket.header = MAKEHEADER(cableNumber, cin);
@lathoub
Copy link
Owner

lathoub commented May 6, 2021

Thanks @YuuichiAkagawa for spotting - if you make a PR, I happily accept

@lathoub lathoub mentioned this issue May 6, 2021
Open
@YuuichiAkagawa YuuichiAkagawa mentioned this issue May 6, 2021
Merged
@lathoub
Copy link
Owner

lathoub commented May 9, 2021

fixed in PR #10 , thank you @YuuichiAkagawa

@lathoub lathoub closed this as completed May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YuuichiAkagawa @lathoub