feature: improvements to evaluations results table #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geclos
commented
Sep 19, 2024
| @@ -54,7 +54,7 @@ export const withProject = createServerActionProcedure(authProcedure) | |||
| return { ...ctx, project } | |||
| }) | |||
|
|
|||
| export const widthDocument = createServerActionProcedure(withProject) | |||
| export const withDocument = createServerActionProcedure(withProject) | |||
There was a problem hiding this comment.
typo @andresgutgon 😂
geclos
force-pushed
the
feature/improvements_to_evaluations_results_table
branch
from
c58d6a7
to
1c848d4
Compare
Fixes queue ordering as evaluations were being run after all document runts had completed which is not the best experience. Also added interval fetching of the table data to simulate real time experience. Finally, added collapsable convos in the log messages section in order to make that section more readable. To further improve this we need: 1. Decouple expensive queries from this view so that we can query table logs more freely 2. Add an independent queue dedicated to running evaluations in order to increase parallelism between document and evaluation runs
geclos
force-pushed
the
feature/improvements_to_evaluations_results_table
branch
from
1c848d4
to
2bafdc3
Compare
|
🐮 👦🏼 |
geclos
deleted the
feature/improvements_to_evaluations_results_table
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes queue ordering as evaluations were being run after all document runts had completed which is not the best experience.
Also added interval fetching of the table data to simulate real time experience.
Finally, added collapsable convos in the log messages section in order to make that section more readable.
To further improve this we need: