Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to disable SSL #515

Open
Proximyst opened this issue Jul 13, 2020 · 6 comments
Open

Feature to disable SSL #515

Proximyst opened this issue Jul 13, 2020 · 6 comments
Labels
needs rust feature This issue or PR needs a Rust feature to be stabilized before it can be merged into master

Comments

@Proximyst
Copy link

I'm writing a service which is designed to be ran in Docker where SSL really only adds unnecessary overhead and is as such not used. I'd love for a feature gate to disable SSL altogether in this crate. I personally do not care if SSL is enabled by default, as long as it is possible to remove SSL.

Thank you! :)

@mehcode
Copy link
Member

mehcode commented Jul 13, 2020

Depends on the database. For instance, you can add ?sslmode=disable for postgres.

@Proximyst
Copy link
Author

I'm aware how to disable the SSL from the connection, I'm saying I'd prefer if I didn't have a dependency on the openssl crate at all. This is completely fine if you smack a "priority: low" or something label on, though, as it's not exactly a problem per se.

@ivan
Copy link
Contributor

ivan commented Jul 13, 2020

I have problems with the openssl crate as well on NixOS. I can either get fast linking with lld or working openssl linking, but not both.

Edit: I just noticed things works fine for me with #473 (comment), thank you for that very helpful pointer.

@mehcode mehcode added the needs rust feature This issue or PR needs a Rust feature to be stabilized before it can be merged into master label Jul 19, 2020
@mehcode
Copy link
Member

mehcode commented Jul 19, 2020

@Proximyst This is unfortunately blocked on: rust-lang/cargo#3494

@juchiast
Copy link

I think this is possible in rust 1.60 https://blog.rust-lang.org/2022/04/07/Rust-1.60.0.html

@abonander
Copy link
Collaborator

Pending fixes in #2039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rust feature This issue or PR needs a Rust feature to be stabilized before it can be merged into master
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants