Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csp_port shape hack #51

Open
PhilippPlank opened this issue Nov 15, 2021 · 5 comments
Open

Fix csp_port shape hack #51

PhilippPlank opened this issue Nov 15, 2021 · 5 comments
Assignees
Labels
0-needs-review For all new issues 1-feature New feature request

Comments

@PhilippPlank
Copy link
Contributor

Currently a csp_port has a fixed shape to send data. Sometimes though, a "header" is additional needed, which is likely to have a different shape as the data.

Example:

Originally posted by @awintel in #46 (comment)

@mgkwill
Copy link
Contributor

mgkwill commented Nov 16, 2021

+1

We are running into similar issues.

@mgkwill mgkwill added this to the Release v0.2.0 milestone Nov 16, 2021
@awintel
Copy link
Contributor

awintel commented Nov 16, 2021

We could transmit header information via the token queue or flatten the arrays?
Other suggestions?

@PhilippPlank
Copy link
Contributor Author

What are the requirements for Loihi with respect to channels?
Would it be more efficient to internally create a second channel for the header information only, to keep the amount of data sent per read/write constant?

@awintel
Copy link
Contributor

awintel commented Nov 17, 2021

For Loihi the Channel implementation will be different. We won't use PyPyChannels in this case but the lower level "Andrew"-CSP package as you know in which everything just gets serialized into flat bytes.

We could have a separate CSP channel increasing the number to 3 different things we have to transact information over. We might just use the Queue for that, which we already use to transact the synchronization tokes.

We should probably pull Harry into this discussion because we have to keep performance in mind.

@awintel awintel modified the milestones: Release v0.2.0, Sprint #16 Nov 22, 2021
@mgkwill mgkwill modified the milestones: -Sprint #16, feature_csp_channel Dec 2, 2021
@mathisrichter mathisrichter added the 0-needs-review For all new issues label Jan 3, 2023
@mathisrichter mathisrichter removed this from the feature_csp_channel milestone Jan 3, 2023
@tim-shea
Copy link
Contributor

tim-shea commented Jan 17, 2024

Unless I've missed something in the past couple months, I believe this is still not fixed, is that right @ysingh7 @joyeshmishra? Can we make time to fix this?

EDIT: Oops, this comment belongs on the set_var as vector issue. Do you know the status of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-needs-review For all new issues 1-feature New feature request
Projects
None yet
Development

No branches or pull requests

6 participants