-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Muted segments getting completely skipped #1139
Comments
I have replicated the "audio pausing" by watching a muted stream with the windows photo app, when exporting the audio stream via FFmpeg This issue is kind of in the same boat as #1123; I'm not really sure there's anything I can do without reverting #1103, which fixed a few separate issues itself. |
I haven't taken a look at the code but I believe the issue is the audio stream is in different position in muted versus non-muted segments. Muted segments have the audio stream in position 2.
Normal segments have the audio stream in position 0.
I switched the audio track positions for all muted segments.
#!/bin/bash
for file in *-muted.ts; do
if [ -f "$file" ]; then
echo "Processing $file..."
temp_file="temp_$file"
ffmpeg -i "$file" -map 0:2 -map 0:1 -map 0:0 -c copy "$temp_file"
if [ $? -eq 0 ]; then
mv "$temp_file" "$file"
echo "successfully processed and replaced $file"
else
echo "error processing $file"
rm -f "$temp_file"
fi
fi
done Concatenating the segments into a video results in a playable mp4 that has audio in non-muted segments, as expected. It also works in the Windows photo/video app.
I've had nothing but issues with the audio from muted segments, especially from live streams with the 'ad is playing' screen. |
Nice catch! I saw that the muted segments still contained the audio streams, but completely missed that the order was different. |
I will be releasing the fix for this soon, but I wanted to see about improving clip quality handling first (properly support |
omg thank you so much! |
Checklist
Edition
Windows GUI Application
So I downloaded a vod and when watching on my computer the muted segments get completely skipped and the video bugs a little bit to catch up with the skipped audio. Uploading the vod directly to youtube seems to make it work fine but when I edit in the chat and render the whole thing, the audio for the muted segments is skipped which makes it desynced to the video. Also, if that could help, I tried watching the vod in VLC and it worked perfectly but when visualising the audio it seems that the muted segments only pause the audio instead of it being silent.
I'm sorry if this is unclear and if it is feel free to ask me more info.
The text was updated successfully, but these errors were encountered: