Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] chatdownload does not reach 100% #1150

Closed
2 tasks done
superbonaci opened this issue Jul 11, 2024 · 3 comments · Fixed by #1152
Closed
2 tasks done

[CLI] chatdownload does not reach 100% #1150

superbonaci opened this issue Jul 11, 2024 · 3 comments · Fixed by #1152
Labels
bug Something isn't working

Comments

@superbonaci
Copy link
Contributor

Checklist

Edition

Both

Describe your issue here

Only 99%:

TwitchDownloaderCLI chatdownload -u 2193121344 -o output.html -E --temp-path './temp'
TwitchDownloaderCLI 1.54.9 Copyright (c) lay295 and contributors
[STATUS] - Downloading 99%
[STATUS] - Downloading Embed Images 100%
[STATUS] - Embedding Images 100%
[STATUS] - Writing output file

Add any related files or extra information here

No response
@superbonaci superbonaci added the bug Something isn't working label Jul 11, 2024
@ScrubN
Copy link
Collaborator

ScrubN commented Jul 11, 2024 •
edited
Loading

Is it really that big of a deal? I have used many other CLI tools that also never reach 100% because of floating point rounding.

@superbonaci
Copy link
Contributor Author

Which other CLI tools?

@ScrubN
Copy link
Collaborator

ScrubN commented Jul 12, 2024

This is a waste of my time.

@ScrubN ScrubN mentioned this issue Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup ScrubN/TwitchDownloader
2 participants
@superbonaci @ScrubN