From 1ad157927168a64ac1a1b0a277400a729276107c Mon Sep 17 00:00:00 2001 From: Casper Fu <91219266+hcasperfu@users.noreply.github.com> Date: Wed, 30 Aug 2023 22:23:47 -0700 Subject: [PATCH] Issue2465 remove and3 (#3490) * moved Add3 and validation to Obsolete, updated revision log, added obsolete markings --- .../Subsequences/Limits/SeparateWithDP.mo | 38 ++++-- .../VAV/Economizers/Subsequences/Enable.mo | 33 +++-- .../VAV/Economizers/Subsequences/Limits.mo | 27 ++-- .../CoolingOnly/Subsequences/Alarms.mo | 32 +++-- .../Subsequences/Alarms.mo | 57 ++++++--- .../Subsequences/Alarms.mo | 28 +++-- .../Subsequences/Alarms.mo | 57 ++++++--- .../DualDuctSnapActing/Subsequences/Alarms.mo | 82 +++++++----- .../ParallelFanCVF/Subsequences/Alarms.mo | 114 ++++++++++------- .../ParallelFanVVF/Subsequences/Alarms.mo | 118 +++++++++++------- .../Reheat/Subsequences/Alarms.mo | 57 ++++++--- .../SeriesFanCVF/Subsequences/Alarms.mo | 118 +++++++++++------- .../SeriesFanVVF/Subsequences/Alarms.mo | 118 +++++++++++------- .../OBC/CDL/Logical/Validation/package.order | 1 - .../Controls/OBC/CDL/Logical/package.order | 1 - .../Controls/BaseClasses/ModeCondenserLoop.mo | 33 +++-- .../VAV/Economizers/Subsequences/Enable.mo | 2 +- .../VAV/Economizers/Subsequences/Limits.mo | 2 +- .../Controls/OBC/CDL/Logical/And3.mo | 18 ++- .../OBC/CDL/Logical/Validation/And3.mo | 15 ++- .../OBC/CDL/Logical/Validation/package.order | 1 + .../Controls/OBC/CDL/Logical/package.order | 1 + ...trols_OBC_CDL_Logical_Validation_And3.txt} | 0 .../ConvertBuildings_from_9_to_10.0.0.mos | 6 + .../OBC/CDL/Logical/Validation/And3.mos | 2 +- ...trols.OBC.CDL.Logical.Validation.And3.mos} | 0 .../Examples/BaseClasses/CoolingCoilValve.mo | 33 +++-- Buildings/package.mo | 59 ++++++++- 28 files changed, 698 insertions(+), 355 deletions(-) rename Buildings/{ => Obsolete}/Controls/OBC/CDL/Logical/And3.mo (80%) rename Buildings/{ => Obsolete}/Controls/OBC/CDL/Logical/Validation/And3.mo (75%) rename Buildings/Resources/ReferenceResults/Dymola/{Buildings_Controls_OBC_CDL_Logical_Validation_And3.txt => Buildings_Obsolete_Controls_OBC_CDL_Logical_Validation_And3.txt} (100%) rename Buildings/Resources/Scripts/Dymola/{ => Obsolete}/Controls/OBC/CDL/Logical/Validation/And3.mos (55%) rename Buildings/Resources/Scripts/OpenModelica/compareVars/{Buildings.Controls.OBC.CDL.Logical.Validation.And3.mos => Buildings.Obsolete.Controls.OBC.CDL.Logical.Validation.And3.mos} (100%) diff --git a/Buildings/Controls/OBC/ASHRAE/G36/AHUs/MultiZone/VAV/Economizers/Subsequences/Limits/SeparateWithDP.mo b/Buildings/Controls/OBC/ASHRAE/G36/AHUs/MultiZone/VAV/Economizers/Subsequences/Limits/SeparateWithDP.mo index 92a492594b1..02e8d2bc305 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/AHUs/MultiZone/VAV/Economizers/Subsequences/Limits/SeparateWithDP.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/AHUs/MultiZone/VAV/Economizers/Subsequences/Limits/SeparateWithDP.mo @@ -201,8 +201,11 @@ protected Buildings.Controls.OBC.CDL.Integers.Equal intEqu "Check if operation mode is occupied" annotation (Placement(transformation(extent={{-160,20},{-140,40}}))); - Buildings.Controls.OBC.CDL.Logical.And3 enaMinDam - "Check if the minimum outdoor air damper should be enabled" + Buildings.Controls.OBC.CDL.Logical.And enaMinDam1 + "Check if the minimum outdoor air damper should be enabled, one of two stacked And blocks" + annotation (Placement(transformation(extent={{-100,60},{-80,80}}))); + Buildings.Controls.OBC.CDL.Logical.And enaMinDam2 + "Check if the minimum outdoor air damper should be enabled, one of two stacked And blocks" annotation (Placement(transformation(extent={{-40,60},{-20,80}}))); Buildings.Controls.OBC.CDL.Reals.Sources.Constant one( final k=1) "Constant" @@ -315,24 +318,20 @@ equation {-42,-98}}, color={0,0,127})); connect(moaP.y, gai.u) annotation (Line(points={{-98,-90},{-90,-90},{-90,-120}, {-82,-120}}, color={0,0,127})); - connect(enaMinDam.y, enaRetDamMin.u1) annotation (Line(points={{-18,70},{-10,70}, - {-10,10},{38,10}}, color={255,0,255})); + connect(enaMinDam2.y, enaRetDamMin.u1) annotation (Line(points={{-18,70},{-10, + 70},{-10,10},{38,10}}, color={255,0,255})); connect(les.y, enaRetDamMin.u2) annotation (Line(points={{-18,-30},{10,-30},{10, 2},{38,2}}, color={255,0,255})); connect(enaRetDamMin.y, enaDis.u) annotation (Line(points={{62,10},{78,10}}, color={255,0,255})); - connect(enaMinDam.y, disMinDam.u) annotation (Line(points={{-18,70},{-10,70},{ - -10,-60},{-2,-60}}, color={255,0,255})); + connect(enaMinDam2.y, disMinDam.u) annotation (Line(points={{-18,70},{-10,70}, + {-10,-60},{-2,-60}}, color={255,0,255})); connect(disMinDam.y, disRetDamMin.u1) annotation (Line(points={{22,-60},{38,-60}}, color={255,0,255})); connect(gre.y, disRetDamMin.u2) annotation (Line(points={{-18,-90},{30,-90},{30, -68},{38,-68}},color={255,0,255})); connect(disRetDamMin.y, enaDis.clr) annotation (Line(points={{62,-60},{70,-60}, {70,4},{78,4}}, color={255,0,255})); - connect(greThr.y, enaMinDam.u1) annotation (Line(points={{-58,150},{-50,150},{ - -50,78},{-42,78}}, color={255,0,255})); - connect(intEqu.y, enaMinDam.u3) annotation (Line(points={{-138,30},{-60,30},{-60, - 62},{-42,62}}, color={255,0,255})); connect(minDp.y, maxRetDam.u_s) annotation (Line(points={{-98,170},{118,170}}, color={0,0,127})); connect(dpMinOutDam, maxRetDam.u_m) @@ -361,10 +360,8 @@ equation annotation (Line(points={{-178,-170},{240,-170}}, color={0,0,127})); connect(outDamPhyPosMaxSig.y, yOutDam_max) annotation (Line(points={{-178,-210},{240,-210}}, color={0,0,127})); - connect(enaMinDam.y, y1MinOutDam) + connect(enaMinDam2.y, y1MinOutDam) annotation (Line(points={{-18,70},{240,70}}, color={255,0,255})); - connect(u1SupFan, enaMinDam.u2) - annotation (Line(points={{-240,70},{-42,70}}, color={255,0,255})); connect(effAbsOutAir_normalized, pro1.u1) annotation (Line(points={{-240,300}, {-200,300},{-200,306},{-182,306}}, color={0,0,127})); connect(effAbsOutAir_normalized, pro1.u2) annotation (Line(points={{-240,300}, @@ -401,6 +398,14 @@ equation 170},{-90,170},{-90,150},{-82,150}}, color={0,0,127})); connect(one2.y, minDp1.u) annotation (Line(points={{-98,250},{-80,250},{-80,270}, {18,270}}, color={0,0,127})); + connect(intEqu.y, enaMinDam1.u2) annotation (Line(points={{-138,30},{-112,30}, + {-112,62},{-102,62}}, color={255,0,255})); + connect(u1SupFan, enaMinDam1.u1) + annotation (Line(points={{-240,70},{-102,70}}, color={255,0,255})); + connect(greThr.y, enaMinDam2.u1) annotation (Line(points={{-58,150},{-52,150}, + {-52,70},{-42,70}}, color={255,0,255})); + connect(enaMinDam1.y, enaMinDam2.u2) annotation (Line(points={{-78,70},{-60,70}, + {-60,62},{-42,62}}, color={255,0,255})); annotation ( defaultComponentName="ecoLim", Icon(coordinateSystem(preserveAspectRatio=false, extent={{-100,-100},{100,100}}), @@ -552,6 +557,13 @@ point. revisions="