Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redesign] implement dark mode #1034

Closed
neb-b opened this issue Feb 21, 2018 · 3 comments
Closed

[redesign] implement dark mode #1034

neb-b opened this issue Feb 21, 2018 · 3 comments
Assignees
Labels
area: ux type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@neb-b
Copy link

neb-b commented Feb 21, 2018

This will include cleaning up all the color variables/removing what we don't need

@neb-b neb-b self-assigned this Feb 21, 2018
@btzr-io
Copy link
Collaborator

btzr-io commented Feb 28, 2018

@seanyesmunt Do you need any help with this ?
I'm currently fixing the dark theme on redesign just to see how will look 👀

BTW redesign is looking awesome 👍

@neb-b
Copy link
Author

neb-b commented Feb 28, 2018

Yeah if you are interested I would love some help with this! Colors across the redesign branch are missing a lot of stuff. I was planning on working on this last so feel free to make a PR to redesign if you would like!

You can check out http://lbry.zzk.fr/explore to get an idea of the new dark mode colors.

@neb-b
Copy link
Author

neb-b commented Feb 28, 2018

@btzr-io I think currently there are a fair bit of color variables that aren't being used. Feel free to delete those/rename any that are confusing.

I know I've used color variables instead of a specific element variables as I've been working on this just to save some time. Ex:

.btn {
  background-color: var(--color-primary);
}

which should be something like

.btn {
  background-color: var(--button-background);
}

Same for color: var(--color-black) instead of color: var(--text-color)

Let me know if you have any questions!

@lyoshenka lyoshenka added this to the Mar 12 (app) milestone Feb 28, 2018
@liamcardenas liamcardenas added type: improvement Existing (or partially existing) functionality needs to be changed area: ux and removed needs: triage labels Mar 2, 2018
@btzr-io btzr-io self-assigned this Mar 3, 2018
@btzr-io btzr-io mentioned this issue Mar 3, 2018
3 tasks
@lyoshenka lyoshenka removed this from the Mar 12 (app) milestone Mar 12, 2018
@neb-b neb-b mentioned this issue Mar 19, 2018
4 tasks
@btzr-io btzr-io mentioned this issue Apr 3, 2018
@neb-b neb-b closed this as completed Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ux type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

5 participants