Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect special LBRY urls to pages in App #1352

Closed
tzarebczan opened this issue Apr 18, 2018 · 1 comment
Closed

Redirect special LBRY urls to pages in App #1352

tzarebczan opened this issue Apr 18, 2018 · 1 comment
Labels
area: ux good first issue level: 1 No knowledge of the existing code required type: new feature New functionality that does not exist yet

Comments

@tzarebczan
Copy link
Contributor

tzarebczan commented Apr 18, 2018

The Issue

Great idea from @robvsmith :

In order to drive engagement to various areas of the LBRY app, i.e. Discover, Wallet Overview, Publish or Rewards pages, we need an easy way for user to launch the app and navigate to said pages. This can be done via a https://open.lbry.io link such as https://open.lbry.io/?Rewards (don't click, will cause a green screen) which would then open the LBRY app (if closed) and redirect the user to the respective area.

Changes needed to : https://github.com/lbryio/lbry-app/blob/master/src/main/index.js / https://github.com/lbryio/lbry-app/blob/master/src/main/createWindow.js to handle the ? parameter and navigate the user.

List of possible pages:
https://github.com/lbryio/lbry-app/blob/master/src/renderer/component/router/view.jsx#L30

Want to target these:
discover
invite
publish
getcredits
rewards
settings
wallet
subscriptions

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@tzarebczan tzarebczan added area: ux good first issue level: 1 No knowledge of the existing code required type: new feature New functionality that does not exist yet labels Apr 18, 2018
@tzarebczan
Copy link
Contributor Author

Completed via #1511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ux good first issue level: 1 No knowledge of the existing code required type: new feature New functionality that does not exist yet
Projects
None yet
Development

No branches or pull requests

1 participant