Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "You must wait until thumbnail finishes uploading" message #1821

Closed
jamesbiller opened this issue Jul 25, 2018 · 6 comments
Closed

Create "You must wait until thumbnail finishes uploading" message #1821

jamesbiller opened this issue Jul 25, 2018 · 6 comments
Assignees
Labels
area: creator good first issue help wanted level: 2 Some knowledge of the existing code is recommended type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@jamesbiller
Copy link

I have been loving the new thumbnail upload feature!

However, it's possible that users will attempt to click 'Publish' before their thumbnail is done uploading to spee.ch.

In this case, we should have a message similar to "You must agree to terms and service" that lets them know that they can't publish without the thumbnail being published.
image

I think it makes the most sense if this message only pops up AFTER they click on agreeing to the terms and services. This way they don't see two messages at once saying "You must..." (we don't want to seem too demanding).

This also makes it so that they never see the message until they're actually ready to publish and the thumbnail upload is the only thing preventing them from it.

@tzarebczan
Copy link
Contributor

tzarebczan commented Jul 25, 2018

I was aware of this but didn't file because once the new wallet is implemented, the response time from speech should be a couple seconds.

Let's keep open until it's confirmed.

@jamesbiller
Copy link
Author

You mean it will only take a couple of seconds to upload the thumbnail?

@tzarebczan
Copy link
Contributor

Yes, sorry for not being clearer.

@kauffj
Copy link
Member

kauffj commented Jul 25, 2018

This is a good issue and worth fixing even with a performance improvement to spee.ch since you never know when a request will hang.

However, from a UX perspective the proper behavior is not to error (since nothing unexpected or incorrect is happening) but to simply provide feedback that the thumbnail is still pending. Once it's no longer pending, the publish should finish automatically, with no click required by the user.

@tzarebczan
Copy link
Contributor

Agreed, we should implement this regardless. I may take a stab at it this weekend, shouldn't be too difficult.

@tzarebczan tzarebczan added type: improvement Existing (or partially existing) functionality needs to be changed help wanted good first issue level: 2 Some knowledge of the existing code is recommended area: creator and removed needs: triage labels Jul 26, 2018
@tzarebczan tzarebczan self-assigned this Aug 6, 2018
@tzarebczan
Copy link
Contributor

Closed via #1867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: creator good first issue help wanted level: 2 Some knowledge of the existing code is recommended type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

5 participants