Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Available rewards not refreshed after reward is claimed #596

Closed
tzarebczan opened this issue Sep 20, 2017 · 3 comments
Closed

Available rewards not refreshed after reward is claimed #596

tzarebczan opened this issue Sep 20, 2017 · 3 comments
Labels
help wanted level: 2 Some knowledge of the existing code is recommended type: bug Existing functionality is wrong or broken

Comments

@tzarebczan
Copy link
Contributor

The Issue

If you claim a reward, it still shows it on the list of available rewards. After doing a Developer>Reload, it then disappears. If you click on it again, tells you its already been claimed. Probably just need to refresh the list after claiming.

Steps to reproduce

  1. Redeem a Reward
  2. Reward stays on top section with available rewards

Expected behaviour

Remove claimed Reward from list after it is claimed successfully

Actual behaviour

Reward looks available

System Configuration

  • LBRY Daemon version: 0.16.1
  • LBRY App version: 016RC7
  • LBRY Installation ID:
  • Operating system: Windows

Anything Else

Screenshots

reward already claimed
@tzarebczan tzarebczan added type: bug Existing functionality is wrong or broken contributor friendly labels Sep 20, 2017
@liamcardenas
Copy link
Contributor

@tzarebczan according to @daovist, this is no longer happening

@tzarebczan
Copy link
Contributor Author

I'm pretty sure this is still happening. The rewards do disappear when the app is refreshed/restarted.

The reward list call must only happen at startup. This also becomes an issue with new rewards, like today's LBRYCast, because users need to refresh to see it.

@tzarebczan tzarebczan reopened this Dec 14, 2017
@liamcardenas liamcardenas added level: 3 Significant knowledge of the existing code is recommended level: 2 Some knowledge of the existing code is recommended help wanted and removed level: 3 Significant knowledge of the existing code is recommended contributor friendly labels Dec 14, 2017
@tzarebczan tzarebczan mentioned this issue Jan 3, 2018
Closed
@tzarebczan
Copy link
Contributor Author

This is fixed on the redesign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted level: 2 Some knowledge of the existing code is recommended type: bug Existing functionality is wrong or broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liamcardenas @tzarebczan