Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandoning claim through tx list results in empty tile in Downloads #960

Closed
tzarebczan opened this issue Jan 24, 2018 · 3 comments
Closed
Labels
Tom's Wishlist type: bug Existing functionality is wrong or broken

Comments

@tzarebczan
Copy link
Contributor

The Issue

If a user abandons a claim using the trash icon in the tx list, the claim is deleted but the file is not removed from LBRY and thus creates a blank tile on the Downloaded list (after accessing the claim once or reloading LBRY). The claim revoke prompt should allow the user to delete the file from LBRY or should just do it automatically (not sure you'd ever want to keep the file in file_list if you are revoking the claim)

Steps to reproduce

  1. remove a published claim via the tx list, wait for block confirmation
  2. go into the downloads area, you will see the published tile
  3. click tile - will show the URL and shows that there is nothing at this location
  4. Go back to Downloads folder - now tile will be blank

abandon

Expected behaviour

Delete file automatically or prompt user

Actual behaviour

File shows in Downloads as blank tile

System Configuration

  • LBRY Daemon version: 0.18.0
  • LBRY App version: 0.19.4
  • LBRY Installation ID:
  • Operating system: Windows

Anything Else

Screenshots

@tzarebczan tzarebczan added type: bug Existing functionality is wrong or broken needs: triage labels Jan 24, 2018
@liamcardenas liamcardenas added help wanted good first issue level: 2 Some knowledge of the existing code is recommended and removed needs: triage labels Jan 30, 2018
@tzarebczan
Copy link
Contributor Author

If a file exists, we should give the user an option to delete the file from LBRY (and locally if they want) when abandoning a claim.

@daovist daovist self-assigned this Jul 12, 2018
@alyssaoc alyssaoc added this to the Aug 6th (Desktop) milestone Jul 23, 2018
@tzarebczan
Copy link
Contributor Author

This effort would probably start around #895

@daovist daovist removed their assignment Aug 7, 2018
@alyssaoc alyssaoc removed this from the Aug 6th (Desktop) milestone Aug 20, 2018
@alyssaoc alyssaoc removed good first issue help wanted level: 2 Some knowledge of the existing code is recommended labels Oct 9, 2018
@tzarebczan
Copy link
Contributor Author

This is no longer an issue, we don't show invalid claims. And Claim abandon will now allow for a delete flag we can pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tom's Wishlist type: bug Existing functionality is wrong or broken
Projects
None yet
Development

No branches or pull requests

4 participants