Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

effective_amount should not be 0 during claim takeover #1476

Closed
neb-b opened this issue Sep 24, 2018 · 2 comments
Closed

effective_amount should not be 0 during claim takeover #1476

neb-b opened this issue Sep 24, 2018 · 2 comments
Labels
area: hub needs: exploration Solution unclear, needs research

Comments

@neb-b
Copy link

neb-b commented Sep 24, 2018

The Issue

If I have a claim that was overtaken, I might want to edit it and up my bid amount to try and take control. If I publish something, then decide I want to try and outbid someone (or realized I forgot to do it when publishing initially), I can't compare my effective_amount to a winning claim's effective_amount because mine will be 0.

Steps to reproduce

  1. Make a publish to lbry://one
  2. Resolve the claim
  3. Notice that effective_amount is 0

Expected behaviour

effective_amount should always be the actual effective amount

Needed for lbryio/lbry-desktop#1940

@tzarebczan
Copy link
Contributor

Related discussions: https://github.com/lbryio/lbryum/issues/158 / lbryio/lbrycrd#203 - which means this probably goes all the way back to the blockchain layer.

@seanyesmunt - as a workaround, if the user's claim is returning 0, it means there is another claim (found by resolving the vanity URL) with a higher bid and correct effective amount - this is the bid they would need to beat. In the meantime, we could show their claim bid, not the effective amount, as the current bid (this would work in most situations, besides those that have supports).

@alyssaoc alyssaoc added the needs: exploration Solution unclear, needs research label Sep 25, 2018
@alyssaoc
Copy link
Contributor

closing, reopen if still valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: hub needs: exploration Solution unclear, needs research
Projects
None yet
Development

No branches or pull requests

3 participants