Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update channel balance checking to match claim #1148

Merged
merged 3 commits into from
Mar 17, 2018
Merged

Conversation

tzarebczan
Copy link
Contributor

Simple balance check before calling get_max_usable_balance_for_claim - matches what happens on the claim.

Also provide clearer error message about maximum amount

Simple balance check before calling get_max_usable_balance_for_claim - matches what happens on the claim.

Also provide clearer error message about maximum amount
@lbryio lbryio deleted a comment Mar 15, 2018
Copy link
Contributor

@hackrush01 hackrush01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lbryio lbryio deleted a comment Mar 16, 2018
@hackrush01 hackrush01 merged commit 1d9c996 into master Mar 17, 2018
@lyoshenka lyoshenka deleted the channel-bid branch March 25, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants