Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ParticleID objects are not always filled #69

Closed
tmadlener opened this issue Feb 19, 2024 · 2 comments
Closed

Some ParticleID objects are not always filled #69

tmadlener opened this issue Feb 19, 2024 · 2 comments

Comments

@tmadlener
Copy link

For example the RefinedVertex PID object is only conditionally filled. From having had a quick look at the code this seems to mainly be done for some internal caching(?).

I am mainly opening this issue since I have stumbled over this while updating the LCIO <-> EDM4hep conversion for accommodating key4hep/EDM4hep#268 . I am not sure if there is an easy fix, but I would at least like to have some paper trail to document the reason for some implementations that might need to work around this fact.

@Zehvogel
Copy link

This is also an issue for the jet clustering. In particular when there is an event where no jet is found no PID object is created.

@tmadlener
Copy link
Author

Closing this since iLCSoft/LCIO#193 and iLCSoft/MarlinReco#135 make it possible to let the user decide whether they want all of the collections have this or none of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants