Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS for -webkit-tap-highlight-color, fixes #5302 #5303

Merged
merged 1 commit into from
Feb 7, 2017

Conversation

IvanSanchez
Copy link
Member

fixes #5302

@IvanSanchez IvanSanchez added this to the 1.1 milestone Feb 3, 2017
Copy link
Member

@perliedman perliedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we apply more specific rules? These will hit styling in popups etc., which I think has been a common source of frustration earlier on. If it's just SVGs, maybe we can target just those - or is this also a problem for other elements?

Also: Chrome 55 starts to feel like version WTF.

@IvanSanchez
Copy link
Member Author

If it's just SVGs, maybe we can target just those - or is this also a problem for other elements?

As far as I could tell, elements such as marker <img>s and the zoom controls were also affected. :-(

That's why I'm adding the rule to the whole container.

@perliedman perliedman merged commit fa458e7 into master Feb 7, 2017
@mourner mourner deleted the tap-highlight-color branch March 20, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome>55 highlights SVG paths on tap
2 participants