Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity check to prevent loading tiles when bounds are Infinity #5478

Merged
merged 2 commits into from
Apr 25, 2017
Merged

Sanity check to prevent loading tiles when bounds are Infinity #5478

merged 2 commits into from
Apr 25, 2017

Conversation

IvanSanchez
Copy link
Member

Fixes #5477

@IvanSanchez IvanSanchez added this to the 1.1 milestone Apr 25, 2017
perliedman
perliedman approved these changes Apr 25, 2017
View reviewed changes
Copy link
Member

@perliedman perliedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@perliedman perliedman merged commit 6d6b076 into master Apr 25, 2017
@IvanSanchez
Copy link
Member Author

@perliedman Wait, this didn't take into account the case of -Infinity

@IvanSanchez
Copy link
Member Author

Huh. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/isFinite

@perliedman
Copy link
Member

@IvanSanchez doh, so much for my reviewing skills! 😞

@IvanSanchez IvanSanchez mentioned this pull request Apr 25, 2017
Merged
@IvanSanchez IvanSanchez mentioned this pull request Nov 27, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perliedman perliedman perliedman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanSanchez @perliedman