Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reference.html symlink with redirect #5493

Conversation

alyhegazy
Copy link

@alyhegazy alyhegazy commented May 3, 2017

No description provided.

Copy link
Member

@perliedman perliedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there and thanks for submitting this!

Have you tried and verified that this works locally? I think @IvanSanchez tried this approach but couldn't make it work, so I just want to make sure this actually works and not just in theory.

@alyhegazy
Copy link
Author

Yes, worked fine for me using bundle exec jekyll serve.

Copy link
Member

@perliedman perliedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Ok, let's try this live!

@perliedman perliedman merged commit b6d2165 into Leaflet:master May 4, 2017
@perliedman
Copy link
Member

@alyhegazy looks like it's working on the live site as well. Thanks for submitting this!

@alyhegazy
Copy link
Author

@perliedman anytime!

@alyhegazy alyhegazy deleted the replace-reference.html-symlink-with-redirect branch May 4, 2017 14:54
@cherniavskii cherniavskii mentioned this pull request Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants