Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Boot 3 Support? #133

Closed
ErtugrulSener opened this issue Jun 4, 2023 · 12 comments
Closed

Spring Boot 3 Support? #133

ErtugrulSener opened this issue Jun 4, 2023 · 12 comments

Comments

@ErtugrulSener
Copy link
Contributor

Anyone knows if we can use graphql-spqr with Spring Boot 3?
Is there any plans on doing that?

Could I maybe help, by just "testing" if this works and pointing out what needs to be changed? Maybe even do some changes?

@kaqqao kaqqao transferred this issue from leangen/graphql-spqr Jun 4, 2023
@kaqqao
Copy link
Member

kaqqao commented Jun 4, 2023

Technically, only one single line needs to change (apart from bumping the dependency versions) to make it compatible with Spring Boot 3 (javax -> jakarta package change).
I have somewhat lofty goals for the next version of the starter, and am knee-deep in that. But instead of finishing all that before I release a Spring Boot 3 compatible version, I should just make the minimal changes and publish an intermediary release to enable people to use it while I'm working on the new stuff... I'll do this by next weekend.

@ErtugrulSener
Copy link
Contributor Author

Technically, only one single line needs to change (apart from bumping the dependency versions) to make it compatible with Spring Boot 3 (javax -> jakarta package change).

I have somewhat lofty goals for the next version of the starter, and am knee-deep in that. But instead of finishing all that before I release a Spring Boot 3 compatible version, I should just make the minimal changes and publish an intermediary release to enable people to using it while I'm working on the new stuff... I'll do this by next weekend.

That sounds awesome! ❤️

@ErtugrulSener
Copy link
Contributor Author

Technically, only one single line needs to change (apart from bumping the dependency versions) to make it compatible with Spring Boot 3 (javax -> jakarta package change).

I have somewhat lofty goals for the next version of the starter, and am knee-deep in that. But instead of finishing all that before I release a Spring Boot 3 compatible version, I should just make the minimal changes and publish an intermediary release to enable people to use it while I'm working on the new stuff... I'll do this by next weekend.

Hey @kaqqao - You still working on that? You need a helping hand?

@russm3086
Copy link

Technically, only one single line needs to change (apart from bumping the dependency versions) to make it compatible with Spring Boot 3 (javax -> jakarta package change).
I have somewhat lofty goals for the next version of the starter, and am knee-deep in that. But instead of finishing all that before I release a Spring Boot 3 compatible version, I should just make the minimal changes and publish an intermediary release to enable people to use it while I'm working on the new stuff... I'll do this by next weekend.

Hey @kaqqao - You still working on that? You need a helping hand?

Any update?

@manshanb
Copy link

@kaqqao Any update on this ? As springboot 2.7 is nearing End of Life, upgrade to Springboot 3 is critical for us.

@mdtamim
Copy link

mdtamim commented Jun 27, 2023

@kaqqao I see code changes related to Spring Boot 3 has been merged to the main branch.Can you please release a major version also so that we can start pulling that dependency from Maven repo?

@ErtugrulSener
Copy link
Contributor Author

The PR by @SaschaPeukert has been accepted, now we need a new version.
Should we choose "1.0.0" as this is a major update?

@kaqqao

@kaqqao
Copy link
Member

kaqqao commented Jun 27, 2023

Should we choose "1.0.0" as this is a major update?

I... don't know 😓 The version after this will be based on the Spring GraphQL starter, so another major change...
I either name this 1.0.0 and the next 2.0.0 already, or we still keep 0.x even though this is a big change... I don't like either proposition too much 🫤
What do you say?

@mdtamim
Copy link

mdtamim commented Jun 27, 2023

I don't have issues with 0.x but would vote to go with major release version ie.. 1.0.0 because it follows Semantic Versioning rule

@ErtugrulSener
Copy link
Contributor Author

I don't have issues with 0.x but would vote to go with major release version ie.. 1.0.0 because it follows Semantic Versioning rule

Do we have breaking changes? Yes, since the java ee namespace is called jakarta now, so the user can't use the new version without changes on his code.

So following SemVer it should be "1.0.0". Versions don't cost anything, if the change to Spring GraphQL Starter has breaking changes for the user again, it will be "2.0.0", so what. It's okay I think, Mozilla / Chrome has Versions 100+ and nobody cares 💫

@kaqqao
Copy link
Member

kaqqao commented Jun 27, 2023

Ok.
This release will be 1.0.0 (making 1.x the classic SPQR Starter branch) and the Spring GraphQL starter based ones will be 2.x. Seems nice and intuitive enough.

@kaqqao
Copy link
Member

kaqqao commented Jun 27, 2023

Released v1.0.0

@kaqqao kaqqao closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants