Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot testing #858

Open
zefirka opened this issue Jul 29, 2023 · 0 comments
Open

Screenshot testing #858

zefirka opened this issue Jul 29, 2023 · 0 comments

Comments

@zefirka
Copy link
Contributor

zefirka commented Jul 29, 2023

Hi there, long time no see 😄

Things is we're using uPlot as a core library for our own featurefull library. Currently I'm focused on improving stability and reduce regressions in our library, so I decided to cover it with screenshot tests. I think that fundamental tests (like a visualisation types, series and axes rendering) should cover uPlot, not our library, cuz it's actually uPlot's tests and it's better to keep them in uPlot's repo.

What do you think about screenshot testing? I setup screenshot testing in our repo and I can easily setup the same in uPlot and bring some base tests. I'm simply using puppeteer + jest to take screenshots, I was thinking about only-canvas approach, but found out that eventually I'll want to test interaction with HTML elements etc, so I stick with browser screenshots. If you don't like my approach, we can discuss it and modify for uPlot. Anyway I found that tests would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant