Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRICK_PRIMARY vs NPRIMARY #714

Open
rongpu opened this issue Oct 12, 2022 · 0 comments
Open

BRICK_PRIMARY vs NPRIMARY #714

rongpu opened this issue Oct 12, 2022 · 0 comments

Comments

@rongpu
Copy link
Contributor

rongpu commented Oct 12, 2022

(Reposting this from decam-chatter to better keep track of the issues.)

The "BRICK_PRIMARY" value in the tractor catalog does not always match the "NPRIMARY" bit in "MASKBITS". This happens for a small number of objects (a few hundred objects in a sweep catalog). The plot below shows (in red points) objects with the NPRIMARY bit set in a sweep catalog (which by definition only contains BRICK_PRIMARY==0 objects). Clearly they are all along the brick boundaries. I wonder if it's because each value is defined differently (perhaps BRICK_PRIMARY is based on geometry, while NPRIMARY is based on the maskbits pixel images).

In any case, we should figure out if the NPRIMARY mask bit in the sweep catalogs should ever be used, and specifically, if requiring NPRIMARY=0 would remove unique real sources. If that is the case, we should put a clear warning in the documentation not to use this bit.

image (3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant