Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] bump fvm to support Dart 2.18.x #474

Closed
subzero911 opened this issue Sep 24, 2022 · 21 comments
Closed

[BUG] bump fvm to support Dart 2.18.x #474

subzero911 opened this issue Sep 24, 2022 · 21 comments
Labels
bug Something isn't working

Comments

@subzero911
Copy link

subzero911 commented Sep 24, 2022

image

fvm v2.4.1

@subzero911 subzero911 added the bug Something isn't working label Sep 24, 2022
@leoafarias
Copy link
Owner

@subzero911 does the issue happen when installing FVM through chocolatey also?

@subzero911
Copy link
Author

@subzero911 does the issue happen when installing FVM through chocolatey also?

Yes, I installed it through chocolatey

@subzero911
Copy link
Author

subzero911 commented Nov 1, 2022

@leoafarias could it be solved, if being installed not through choco, but through pub activate global?

Btw, it's dart 2.18.3 latest now

@JaffaKetchup
Copy link

I've run into this issue as well!

@subzero911
Copy link
Author

Meanwhile, the next Dart version, 2.19.1, is out...

@leoafarias
Copy link
Owner

@subzero911 sorry for the delay on this again. I have to review a bit more in detail on why this issue is happening so often, I think maybe the constraints on FVM are incorrect, as it should not be happening with that much frequency

@leoafarias
Copy link
Owner

@subzero911 after doing a bit more research I don't think just upgrading the Dart version is a good solution for this, this might only help your case on Chocolatey since you want to have the latest version of Dart, but that is very restrictive for many other use cases including the pub global actiavate.

I am doing a bit of research to understand how the chocolatey version is being built and deployed, as we use a package called cli_pkg for that.

@JaffaKetchup
Copy link

Hey @leoafarias, great work so far :) Is there any luck from your research?

@stale
Copy link

stale bot commented Apr 28, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 28, 2023
@JaffaKetchup
Copy link

Hey, this ain't stale! Although I do fear FVM has been somewhat abandoned, which is a shame: I hope I'm wrong!

@stale stale bot removed the wontfix This will not be worked on label Apr 30, 2023
@JaffaKetchup
Copy link

@leoafarias With the release of Dart 3, this issue is now vastly more important! I would volunteer to help fix it, but unfortunately, I have no experience with Chocolatey internals.

@subzero911
Copy link
Author

subzero911 commented May 11, 2023

@leoafarias why it's such a bad idea to upgrade it manually?
I checked out other packages, and their authors just do it

image

Meanwhile, we can file an issue to the Flutter repository and ask why dependency constraints do not work as expected (^2.16.0 should support 2.18.0 and all versions <3.0.0, but it's not the case).

@leoafarias
Copy link
Owner

It's not that we can't, but because fvm is a version manager it means that we need loser versions to guarantee compatibility with as many possible environments as possible.

A package like mobx can be more aggressive, also I haven't had time to take a deeper look but I am still no clear on root of the problem since I don't see this happening with our internal use.

@JaffaKetchup
Copy link

Just to note, if using the standalone installation instructions, this issue doesn't occur. You can then just set the system PATH manually.

@leoafarias
Copy link
Owner

@subzero911 there has been an update on cli_pkg which I think it addresses this problem. "hopefully", next version will have that fix

@subzero911
Copy link
Author

Hi! That's great news!

@Chappie74
Copy link

Hey any updates on upgrading the dart version?
Currently unable to make use of dart 3.0.

image

@leoafarias
Copy link
Owner

I suggest using the standalone binaries, brew or chocolatey. For the next version we will release an easier way to install the binaries also.

@Chappie74
Copy link

@leoafarias this was with chocolately. I have both dart and fvm installed using that.

I am however able to work around it by pointing vs code to the dart sdk of the particular flutter version used via fvm.

@leoafarias
Copy link
Owner

@Chappie74 next week we will be releasing the next version which should hopefully address this issue

@leoafarias
Copy link
Owner

This is closed. The deploy actions for chocolatey and brew will now pin the compiled version to avoid this going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants