Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit: current_chunk_incomplete -> current_chunk_complete #14

Open
tbarton16 opened this issue Aug 7, 2023 · 1 comment
Open

Nit: current_chunk_incomplete -> current_chunk_complete #14

tbarton16 opened this issue Aug 7, 2023 · 1 comment

Comments

@tbarton16
Copy link

As far as I understand,current_chunk_incomplete denotes when the streamer has not finished writing the archives in the dir. It never gets renamed to current_chunk_complete so the user doesn't know when commit() has finished. If I am misunderstanding, please let me know.
@lfoppiano
Copy link

@tbarton16 The file gets renamed, but a new one is created every time. So the last one is not cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lfoppiano @tbarton16