Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writes content to disk, even for cache hits when "Use CrawlCache" is ON #850

Closed
utchy opened this issue Mar 1, 2022 · 2 comments · Fixed by #851
Closed

Writes content to disk, even for cache hits when "Use CrawlCache" is ON #850

utchy opened this issue Mar 1, 2022 · 2 comments · Fixed by #851

Comments

@utchy
Copy link
Contributor

utchy commented Mar 1, 2022

Suggestion to improve crawling job.

  • Skip writing content to reduce I/O write if cache exists.
  • Make cache only if status code is not 404.
  • Delete crawl queue from database to prevent crawling urls again, which are not found.
  • Delete previously generated files under the directories both the crawled and the processed.

FYI

I'm preparing a pull request to fix this issue.

@utchy utchy mentioned this issue Mar 1, 2022
@thecodeassassin
Copy link
Contributor

@utchy even with your changes applied CrawlCache is still not working. Even if I update a single posts it crawls ALL pages

@utchy
Copy link
Contributor Author

utchy commented Mar 7, 2022

@thecodeassassin
Thanks for your comment. Ah, yes the plugin actually always crawls even with applying my changes, but never writes again. Before the changes, the plugin always crawls and "writes" on disk. So, please check your file modified date under wp2static-crawled-site directory if pages (and related pages) which you updated are only modified. Cheers.

@leonstafford leonstafford changed the title Always fully crawls even the "Use CrawlCache" is ON Writes content to disk, even for cache hits when "Use CrawlCache" is ON Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants