Fix crawl redirect errors #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a "Too Many Redirects" error when a fresh site redirects twice to go from `/` to the actual post front page.
So that we can have a place to start debugging when we encounter a "Too Many Redirects" error.
bookwyrm
referenced
this pull request
Oct 11, 2021
When creating a Psr7 request with a base_uri set in the Client and a path that starts with // (like '//wp-sitemap.xml'), the path is interpreted as an absolute URL and we get a ClientException for 'unknown host: wp-sitemap.xml'. This is fixed by removing base_uri from the client and always making Requests with the full url. This was discovered while debugging #824 and may address that issue.
Based on feedback from team, it makes more sense to simply log the error in the standard way and keep going with the crawl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow two redirect hops to support new WP instance crawl behavior.
Report on errors from too many redirects in CLI for debugging.