Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch error: not found #416

Open
slorber opened this issue Mar 9, 2021 · 4 comments
Open

Fetch error: not found #416

slorber opened this issue Mar 9, 2021 · 4 comments
Labels

Comments

@slorber
Copy link

slorber commented Mar 9, 2021

I'm trying to release a new Docusaurus version and got a weird error when generating the changelog.

In the downloadIssueData I added a try/catch and noticed it tries to fetch an issue that does not seem to exist 🤪

image

image

And nothing can be found at facebook/docusaurus#4018

I don't know if it's Github API that should not return 4018 in the first place, or a bug in Lerna, just wanted to report this issue.

However I think it could be useful to add an option to fail-safe in case of such fetch errors, or at least print the issue number in the error message so that user does not have to hack inside the library code to find the reason this fails?

@Turbo87 Turbo87 added the bug label Mar 10, 2021
@Turbo87
Copy link
Contributor

Turbo87 commented Mar 10, 2021

I don't know if it's Github API that should not return 4018 in the first place, or a bug in Lerna, just wanted to report this issue.

we are essentially parsing the commit messages for common merge commit patterns and extracting the issue numbers from that. it could be that this is a false positive, but I agree that it shouldn't error just because of that 😅

@slorber
Copy link
Author

slorber commented Mar 10, 2021

I think having an error printed to the console wouldn't be a big deal.

However when you are in the middle of a release and you are stuck because you can't generate the changelog, it can be more annoying 😅 just adding a try/catch would be a quick win

@runspired
Copy link

@Turbo87 also hitting this in a private repo, it's a bit unclear why. I've set the github token and all PRs are labelled. Anything we can do to make this more debuggable?

@Turbo87
Copy link
Contributor

Turbo87 commented Mar 5, 2022

a PR with a bunch of debug prints maybe 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants