Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that each factory returns a unique db #282

Merged
merged 2 commits into from
Jul 14, 2018
Merged

Test that each factory returns a unique db #282

merged 2 commits into from
Jul 14, 2018

Conversation

ralphtheninja
Copy link
Member

Closes #260

@vweevers
Copy link
Member

Shouldn't each test call setup and teardown?

@ralphtheninja
Copy link
Member Author

Shouldn't each test call setup and teardown?

Guess so. Not all test are doing that still.

@vweevers
Copy link
Member

Or hm, is any implementation actually using setup/teardown? 🤔

@ralphtheninja
Copy link
Member Author

Or hm, is any implementation actually using setup/teardown?

We would have to investigate this further I think.

@ralphtheninja ralphtheninja merged commit 48484ce into master Jul 14, 2018
@ralphtheninja ralphtheninja deleted the test-factory branch July 14, 2018 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphtheninja @vweevers